Missing impressions icon #12644
Merged
Missing impressions icon #12644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeMucientes
commented
Sep 19, 2024
| append(stringResource(id = R.string.blaze_campaign_budget_reach_forecast)) | ||
| appendInlineContent(id = id, alternateText = "[Icon]") | ||
| } | ||
| val inlineContent = mapOf( |
There was a problem hiding this comment.
I ended up inlining the info icon to ensure it looks nice when the text is 2 lines.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
|
Version |
JorgeMucientes
changed the title
hichamboushaba
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12562
Description
Fixes an issue where the ℹ️ icon next to the impression label inside the Blaze budget screen, would go missing if the text was too long.
Steps to reproduce
From
trunkTesting information
Repeat the steps above from this branch and verify that the ℹ️ icon is displayed correctly when the text is one line (English) and when the text is 2 lines (Spanish for example)
The tests that have been performed
Tested Blaze campaign creation flow.
Images/gif
Expected UI:
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: